ashutoshc commented on a change in pull request #552: Hive 21279
URL: https://github.com/apache/hive/pull/552#discussion_r260961687
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
##########
@@ -1553,7 +1568,9 @@ public static void mvFileToFinalPath(Path specPath,
Configuration hconf,
Utilities.FILE_OP_LOGGER.trace("Moving tmp dir: {} to: {}", tmpPath,
specPath);
if(shouldAvoidRename(conf, hconf)){
LOG.debug("Skipping rename/move files. Files to be kept are: " +
filesKept.toString());
- conf.getFilesToFetch().addAll(filesKept);
+ Set<FileStatus> statusFilesToKeep = new HashSet<>();
+ buildFileStatsList(statusList, filesKept, statusFilesToKeep);
Review comment:
Instead of iterating filesKept and statusList again, better to get rid of
filesKept altogether and just have statusKept in its place which is then
populated in removeTempOrDuplicateFiles()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
