sankarh commented on a change in pull request #569: HIVE-21446 : Hive Server
going OOM during hive external table replications
URL: https://github.com/apache/hive/pull/569#discussion_r266297902
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -136,7 +143,11 @@ private void doCopyRetry(FileSystem sourceFs,
List<ReplChangeManager.FileInfo> s
}
// looks like some network outrage, reset the file system object and
retry.
- FileSystem.closeAllForUGI(Utils.getUGI());
+ if (proxyUser == null) {
+ FileSystem.closeAllForUGI(Utils.getUGI());
+ } else {
+ FileSystem.closeAllForUGI(proxyUser);
+ }
sourceFs = pathList.get(0).getFileSystem(hiveConf);
destinationFs = destination.getFileSystem(hiveConf);
Review comment:
We need to propagate the destinationFs to caller as well as caller still
points to old file system object which is invalid. As caller uses this object
in a loop, it is necessary to propagate it back to caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
