maheshk114 commented on a change in pull request #578: HIVE-21471: Replicating conversion of managed to external table leaks HDFS files at target. URL: https://github.com/apache/hive/pull/578#discussion_r268222534
########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/CreateTableOperation.java ########## @@ -108,6 +116,12 @@ private void createTableReplaceMode(Table tbl) throws HiveException { } } + // If table's data location is moved, then set the corresponding flag in environment context to Review comment: comment should be , if the location is changed at source. The comment gives wrong impression that it is done for normal flow also. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services