sankarh commented on a change in pull request #578: HIVE-21471: Replicating
conversion of managed to external table leaks HDFS files at target.
URL: https://github.com/apache/hive/pull/578#discussion_r268479992
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
##########
@@ -99,9 +100,12 @@ public void alterTable(RawStore msdb, Warehouse wh, String
catName, String dbnam
dbname = dbname.toLowerCase();
final boolean cascade = environmentContext != null
- && environmentContext.isSetProperties()
- && StatsSetupConst.TRUE.equals(environmentContext.getProperties().get(
- StatsSetupConst.CASCADE));
+ && environmentContext.isSetProperties()
+ &&
StatsSetupConst.TRUE.equals(environmentContext.getProperties().get(StatsSetupConst.CASCADE));
+ final boolean replDataLocationChanged = environmentContext != null
Review comment:
I think flag is needed as we shouldn't update partition locations if user
set location for a table. That is current behaviour and shouldn't be changed.
Only for repl flow, this is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
