ashutosh-bapat commented on a change in pull request #579: HIVE-21109 : Support
stats replication for ACID tables.
URL: https://github.com/apache/hive/pull/579#discussion_r269476213
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java
##########
@@ -381,4 +382,11 @@ public void setOwnerName(String ownerName) {
throw new RuntimeException("Invalid table type : " + getDescType());
}
}
+
+ public Long getReplWriteId() {
+ if (this.createTblDesc != null) {
+ return this.createTblDesc.getReplWriteId();
Review comment:
In getBaseAddPartitionDescFromPartition() where we use this function, we
don't have access to the event message. Instead we are passing the writeId
through ImportTableDesc by calling setReplWriteId(). This function just
introduces the missing getReplWriteId() method symmetric to setReplWriteId().
If we use local variable and pass it around there is a possibility that local
writeId variable can go out of sync with that in ImportTableDesc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
