> On April 3, 2019, 9:54 p.m., Jason Dere wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > > Line 615 (original), 615 (patched) > > <https://reviews.apache.org/r/70372/diff/1/?file=2136896#file2136896line615> > > > > Just curious about this one, was there a difference between > > rbCtx.getRowColumnTypeInfos() and rbCtx.getDataColumnCount()? Or just the > > fact that rbCtx.getDataColumnCount() directly returns an int value?
Yes. There is place in encoded reader creation that counts just the non-null columns in vector batch. But in here we include all columns including the nulls (partition columns at the last) so the text llap reader was throwing exception. > On April 3, 2019, 9:54 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogSerDe.java > > Lines 57 (patched) > > <https://reviews.apache.org/r/70372/diff/1/?file=2136900#file2136900line57> > > > > Is the list of columns from SyslogSerDe fixed to (facility, severity, > > version, ts, hostname, app_name, proc_id, msg_id, structured_data, msg, > > unmatched)? If so then should the column list/types be hardcoded rather > > than set via LIST_COLUMNS/LIST_COLUMNS_TYPES properties? Yes. It is fixed schema. make sense.. The columns and types doesn't change anyway. Will fix it in next patch. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70372/#review214337 ----------------------------------------------------------- On April 2, 2019, 10:29 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70372/ > ----------------------------------------------------------- > > (Updated April 2, 2019, 10:29 p.m.) > > > Review request for hive, Ashutosh Chauhan and Jason Dere. > > > Bugs: HIVE-21427 > https://issues.apache.org/jira/browse/HIVE-21427 > > > Repository: hive-git > > > Description > ------- > > HIVE-21427: Syslog storage handler > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 777f8b51215523fca8e396ddf77139420666311a > data/files/syslog-hs2-2.log PRE-CREATION > data/files/syslog-hs2.log PRE-CREATION > itests/src/test/resources/testconfiguration.properties > 96dfbc4b56b6eb3dff6b8e1e42a2371d090426e7 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > 9ef7af4eb0c9787a33d2aa4c9a4528b8f356106b > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java > 27fe828b7531584138cd002956a9fcc20f238f71 > ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogInputFormat.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogParser.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogSerDe.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/log/syslog/SyslogStorageHandler.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/log/TestSyslogInputFormat.java > PRE-CREATION > ql/src/test/queries/clientpositive/syslog_parser.q PRE-CREATION > ql/src/test/queries/clientpositive/syslog_parser_file_pruning.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/syslog_parser.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/syslog_parser_file_pruning.q.out > PRE-CREATION > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/MetastoreSchemaTool.java > eafe0c6d46d448bce287e61fabac0384b12b9295 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolCommandLine.java > 6282078411c4c728beed8e957aa857ed3c02133c > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/schematool/SchemaToolTaskCreateLogsTable.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/70372/diff/1/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
