Awesome, thanks Mani! -----Original Message----- From: Mani M <rmsm...@gmail.com> Sent: Tuesday, May 14, 2019 4:48 PM To: dev@hive.apache.org Subject: Re: Code Review for HIVE-14888?
Hi David Currently most of the changes is being reviewed with the help of GitHub pull request. So update your personal fork repo and raise the pull request. With Regards M.Mani +61 432 461 087 On Wed, 15 May 2019, 01:18 David M, <mcginni...@outlook.com> wrote: > All, > > Can I get someone to do a quick review of the code change for > HIVE-14888 ( > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FHIVE-14888&data=02%7C01%7C%7Cf5effbed5a6e4bb32d1a08d6d8c6a613%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636934745025870256&sdata=nk9OfKuRo7z7sWsx%2FN3m3w4bNxe6k0puUxuU%2BlQrNy0%3D&reserved=0)? > It's a simple one-line change that has passed tests and analysis, and is > ready to be pushed. > > I've seen some talk about using GitHub's review functionality or other > tools. Are we still following the documentation on the wiki where we > do the reviews in JIRA, or is there a process change I've missed on > how to formally ask for reviews? > > Thanks! > > David McGinnis > >
