> On June 19, 2019, 9:39 a.m., Marta Kuczora wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > > Lines 1250-1255 (patched) > > <https://reviews.apache.org/r/70867/diff/1/?file=2149584#file2149584line1258> > > > > This code piece is used in multiple methods. Maybe it would make sense > > to extract it to a separate method. > > But since you have some more patches to go around the temp table > > partition handling, it is ok if you consider fixing this in a next patch.
Thanks for pointing this out. I refactored the code and moved this check into another method. > On June 19, 2019, 9:39 a.m., Marta Kuczora wrote: > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientListPartitionsTempTable.java > > Lines 133 (patched) > > <https://reviews.apache.org/r/70867/diff/1/?file=2149585#file2149585line133> > > > > Would it make sense to add test with low max parts number to see if the > > method returns the correct number of partitions? Added two more tests, for checking this use case as well. - Laszlo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70867/#review215960 ----------------------------------------------------------- On June 20, 2019, 9:53 a.m., Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70867/ > ----------------------------------------------------------- > > (Updated June 20, 2019, 9:53 a.m.) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-21814: Implement list partitions related methods on temporary tables > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > b71ef5a725d610cda402717f501f6c6a0f653216 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientListPartitionsTempTable.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/ConditionalIgnoreOnSessionHiveMetastoreClient.java > 99039b08d014cddc9de12e70801267eba7331266 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java > 34ceb34de646cc2e501564e9b3a0cb8cc8a034e1 > > > Diff: https://reviews.apache.org/r/70867/diff/2/ > > > Testing > ------- > > Unit testing is done via > TestSessionHiveMetastoreClientListPartitionsTempTable. > > > Thanks, > > Laszlo Pinter > >
