----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70990/ -----------------------------------------------------------
Review request for hive, Laszlo Bodor, Gopal V, and prasanthj. Bugs: HIVE-21437 https://issues.apache.org/jira/browse/HIVE-21437 Repository: hive-git Description ------- Vectorizer fails for CREATE temporary TABLE `catalog_Sales`( `cs_quantity` int, `cs_wholesale_cost` decimal(7,2), `cs_list_price` decimal(7,2), `cs_sales_price` decimal(7,2), `cs_ext_discount_amt` decimal(7,2), `cs_ext_sales_price` decimal(7,2), `cs_ext_wholesale_cost` decimal(7,2), `cs_ext_list_price` decimal(7,2), `cs_ext_tax` decimal(7,2), `cs_coupon_amt` decimal(7,2), `cs_ext_ship_cost` decimal(7,2), `cs_net_paid` decimal(7,2), `cs_net_paid_inc_tax` decimal(7,2), `cs_net_paid_inc_ship` decimal(7,2), `cs_net_paid_inc_ship_tax` decimal(7,2), `cs_net_profit` decimal(7,2)) ; explain vectorization detail select max((((cs_ext_list_price - cs_ext_wholesale_cost) - cs_ext_discount_amt) + cs_ext_sales_price) / 2) from catalog_sales; SELECT operator: Could not instantiate DecimalColDivideDecimalScalar with arguments arguments: [21, 20, 22], argument classes: [Integer, Integer, Integer], exception: java.lang.IllegalArgumentException Diffs ----- ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalarDecimal.txt 0bd7c004215 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java 0a16e08d61e ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 52e8dcb0904 ql/src/test/queries/clientpositive/vector_decimal_col_scalar_division.q PRE-CREATION ql/src/test/results/clientpositive/perf/spark/query4.q.out a7e317cc3c9 ql/src/test/results/clientpositive/perf/tez/constraints/query4.q.out 293b2816a13 ql/src/test/results/clientpositive/perf/tez/query4.q.out 47515eda2f8 ql/src/test/results/clientpositive/vector_decimal_col_scalar_division.q.out PRE-CREATION Diff: https://reviews.apache.org/r/70990/diff/1/ Testing ------- new q test: vector_decimal_col_scalar_division.q Test Result 16,752 tests 0 failures (-2) , 379 skipped (±0) Thanks, Attila Magyar