----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71038/#review216522 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/util/HiveStrictManagedMigration.java Lines 600 (patched) <https://reviews.apache.org/r/71038/#comment303743> I think we should stop processing ql/src/java/org/apache/hadoop/hive/ql/util/HiveStrictManagedMigration.java Lines 619-620 (patched) <https://reviews.apache.org/r/71038/#comment303741> I think the old behaviour was to stop processing after the first error; and start exiting...right now it will continue as much as it can...and at the end it will print out something depending on this boolean... ql/src/java/org/apache/hadoop/hive/ql/util/HiveStrictManagedMigration.java Lines 695-697 (patched) <https://reviews.apache.org/r/71038/#comment303742> earlier this exception have bubbled up - Zoltan Haindrich On July 11, 2019, 2 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71038/ > ----------------------------------------------------------- > > (Updated July 11, 2019, 2 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez, Jason Dere, Zoltan > Haindrich, and Vineet Garg. > > > Bugs: HIVE-21965 > https://issues.apache.org/jira/browse/HIVE-21965 > > > Repository: hive-git > > > Description > ------- > > Implement parallel processing in HiveStrictManagedMigration > =========================================================== > > 1. Process tables paralelly using a thread pool for each. Thread pools size > can be defined by command line options. If no options are given the default > pool size is the number of cpu cores. > 2. Add option for filtering table type. > > I had to remove database parallel processing because the ForkJoinPool > implementation does not support nested parallel streams. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/util/CloseableThreadLocal.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/util/HiveStrictManagedMigration.java > 80025b7046 > > ql/src/java/org/apache/hadoop/hive/ql/util/NamedForkJoinWorkerThreadFactory.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/TxnCommandsBaseForTests.java > 5f39fdccb5 > ql/src/test/org/apache/hadoop/hive/ql/util/CloseableThreadLocalTest.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/util/TestHiveStrictManagedMigration.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/71038/diff/2/ > > > Testing > ------- > > New UT for testing migration. > > > Thanks, > > Krisztian Kasa > >
