----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71091/#review216796 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java Line 348 (original), 348 (patched) <https://reviews.apache.org/r/71091/#comment304062> unnecessary white space ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Lines 195 (patched) <https://reviews.apache.org/r/71091/#comment304017> Can you add comment to explain why METADATA_FILE and ACID_FORMAT are not filtered out? ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Lines 211 (patched) <https://reviews.apache.org/r/71091/#comment304018> Comment here to explain why directories containing TMP_PREFIX are not filtered out would be nice. ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java Lines 29 (patched) <https://reviews.apache.org/r/71091/#comment304061> Ununsed import statements - Vineet Garg On July 22, 2019, 5:35 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71091/ > ----------------------------------------------------------- > > (Updated July 22, 2019, 5:35 p.m.) > > > Review request for hive, Gopal V and Vineet Garg. > > > Bugs: HIVE-21225 > https://issues.apache.org/jira/browse/HIVE-21225 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-21225 > > > Diffs > ----- > > > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java > 4dc04f46fd > > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java > 78cae7263b > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java > d59cfe51e9 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 295fe7cbd0 > ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java 9d5ba3d310 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java cff7e04b9a > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 707e38c321 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java > b1ede0556f > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java > 15f1f945ce > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 9d631ed43d > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java 57eb506996 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 67a5e6de46 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > 6168fc0f79 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java d4abf4277b > ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java ea31557741 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > b5958fa9cc > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java > 8451462023 > streaming/src/test/org/apache/hive/streaming/TestStreaming.java c6d7e7f27c > > > Diff: https://reviews.apache.org/r/71091/diff/3/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
