----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71243/#review217753 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java Lines 948-952 (patched) <https://reviews.apache.org/r/71243/#comment305120> This can be simplified to: `return tableParameters != null && "true".equals(tableParameters.get(EXTERNAL_PARAM));` It is more compact and also spares a query on the map. - Gergely Hankó On aug. 7, 2019, 8:35 de, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71243/ > ----------------------------------------------------------- > > (Updated aug. 7, 2019, 8:35 de) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-21875: Implement drop partition related methods on temporary tables. > > This is one of the subtasks for HIVE-21765, to support partitions on > temporary tables. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > a2c84b4620fb1eb90069e294204f604565ffed9b > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientDropPartitionsTempTable.java > PRE-CREATION > > service/src/java/org/apache/hive/service/cli/thrift/ThreadPoolExecutorWithOomHook.java > 129413681045d790ae20bf4d8060f04162224565 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > 91c9edac95e9f9688dd2b806aeeb0823af02574f > > > Diff: https://reviews.apache.org/r/71243/diff/1/ > > > Testing > ------- > > Unit testing is done via > TestSessionHiveMetastoreClientDropPartitionsTempTable.java > > > Thanks, > > Laszlo Pinter > >
