-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71606/
-----------------------------------------------------------
Review request for hive and Peter Vary.
Bugs: HIVE-21407
https://issues.apache.org/jira/browse/HIVE-21407
Repository: hive-git
Description
-------
The previous approach didn't solve all use cases. In this new approach the hive
type is sent to the Parquet PPD part and trim the value which is pushed to the
predicate in case of CHAR hive type.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/FilterPredicateLeafBuilder.java
5b051dd
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/LeafFilterFactory.java
fc9188f
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java
033e26a
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/read/ParquetFilterPredicateConverter.java
ca5e085
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetRecordReaderWrapper.java
0210a0a
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/read/TestParquetFilterPredicate.java
7c7c657
ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestConvertAstToSearchArg.java
4c40908
ql/src/test/queries/clientpositive/parquet_ppd_char.q 386fb25
ql/src/test/queries/clientpositive/parquet_ppd_char2.q PRE-CREATION
ql/src/test/results/clientpositive/parquet_ppd_char2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/71606/diff/1/
Testing
-------
Added new q test for testing the PPD for char and varchar types. Also extended
the unit tests for the ParquetFilterPredicateConverter.toFilterPredicate method.
The TestParquetRecordReaderWrapper and the TestParquetFilterPredicate are both
testing the same thing, the behavior of the
ParquetFilterPredicateConverter.toFilterPredicate method. It doesn't make sense
to have tests for the same use case in different test classes, so moved the
test cases from the TestParquetRecordReaderWrapper to
TestParquetFilterPredicate.
Thanks,
Marta Kuczora
