[
https://issues.apache.org/jira/browse/HIVE-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179237#comment-13179237
]
Phabricator commented on HIVE-2279:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2279 [jira] Implement
sort(array) UDF".
INLINE COMMENTS
ql/src/test/queries/clientpositive/udf_sort_array.q:8 Please add EXPLAIN
queries.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:82
Fix indentation.
ql/src/test/results/clientpositive/udf_sort_array.q.out:13
"sort_array(sort_array(...))"?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:45
"Sorts the input array in ascending order according to the natural ordering of
the array elements."
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:55
Please add a negative testcase that exercises these code paths.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:60
What happens if I try to sort an array of arrays, or array of structs?
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:67
The return type should be another ARRAY, not a string.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:85
This method needs to return another ARRAY, not a string containing the
concatenated, sorted input elements. Take a look at the array() UDF for hints
on how to return an array from a UDF.
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java:97
Indentation.
REVISION DETAIL
https://reviews.facebook.net/D1107
> Implement sort(array) UDF
> -------------------------
>
> Key: HIVE-2279
> URL: https://issues.apache.org/jira/browse/HIVE-2279
> Project: Hive
> Issue Type: New Feature
> Components: UDF
> Reporter: Carl Steinbach
> Assignee: Zhenxiao Luo
> Attachments: HIVE-2279.D1059.1.patch, HIVE-2279.D1101.1.patch,
> HIVE-2279.D1107.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
