-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71811/
-----------------------------------------------------------
(Updated Nov. 30, 2019, 10:54 a.m.)
Review request for hive and Zoltan Haindrich.
Bugs: HIVE-22526
https://issues.apache.org/jira/browse/HIVE-22526
Repository: hive-git
Description
-------
The Driver class contains ~600 lines of code responsible for compiling the
command. That means that from the command String a Plan needs to be created,
and also a transaction needs to be started (in most of the cases). This is a
thing done by the compile function, which has a lot of sub functions to help
this task, while itself is also really big. All these codes should be put into
a separate class, where it can do it's job without getting mixed with the other
codes in the Driver.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/Compiler.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 54d12baa96
ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1afcfc8969
ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java 26e904af0b
ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 4d79ebc933
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java fa6c9d03ec
Diff: https://reviews.apache.org/r/71811/diff/3/
Changes: https://reviews.apache.org/r/71811/diff/2-3/
Testing
-------
All the tests are still running fine.
Thanks,
Miklos Gergely
