----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72013/#review219318 -----------------------------------------------------------
Ship it! Ship It! - Jesús Camacho Rodríguez On Jan. 16, 2020, 4:13 p.m., Krisztian Kasa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72013/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2020, 4:13 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-22735 > https://issues.apache.org/jira/browse/HIVE-22735 > > > Repository: hive-git > > > Description > ------- > > TopNKey operator deduplication > ============================== > When creating a TopNKeyDesc ignore `ExprNodeConstantDesc` type columns > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/plan/TopNKeyDesc.java a9e2a527df > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets.q.out > b1ec8d8847 > > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_functions.q.out > 0ec6e6de43 > ql/src/test/results/clientpositive/llap/topnkey_grouping_sets_order.q.out > d3ff1a6256 > > > Diff: https://reviews.apache.org/r/72013/diff/1/ > > > Testing > ------- > > mvn test -Dtest.output.overwrite -DskipSparkTests > -Dtest=TestMiniLlapLocalCliDriver > -Dqfile=topnkey.q,topnkey_dedup.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q,topnkey_order_null.q,vector_topnkey.q > -pl itests/qtest -Pitests > > > Thanks, > > Krisztian Kasa > >
