----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72043/#review219380 -----------------------------------------------------------
Have you tested the sqls on every db? If they run correctly on all supported DB, then +1 from my side Thanks, Peter - Peter Vary On jan. 24, 2020, 10 de, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72043/ > ----------------------------------------------------------- > > (Updated jan. 24, 2020, 10 de) > > > Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-21487: COMPLETED_COMPACTIONS and COMPACTION_QUEUE table missing > appropriate indexes > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > da5dd61d08e2ca8fe5e80ffdf9fb4a6f4c4d0ba3 > > standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql > 67102718867233f29ddb2ea8ec3fbcb6560c6c30 > > standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql > ae0a32541a4bb9179b2bb71ae9f9098d7b35a88e > > standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql > 221d4f1fffb682aaec3af22a339e7a3077a75f6a > > standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql > bc98d5fc4a5637988c97f2e5a0e02d3be16ae0cb > > standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql > dd761a66db4826580a67d64879e4c85278b8e20c > > standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql > 6a040a6a64c2086b5eb68a397697c9e2d2ca4d76 > > standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql > f5ec1ba1aff89d02b66d6a2cd1da8de1b3b08d06 > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > c7738be2732b839aa2b460733c092e368909f935 > > standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql > 455f98b72578ff977e29301cd2fc595ae80ee4ca > > standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql > 5c39b0d9f4d27ab82ef44392818c1810cb7664ce > > > Diff: https://reviews.apache.org/r/72043/diff/1/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
