----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72063/#review219513 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java Lines 88 (patched) <https://reviews.apache.org/r/72063/#comment307708> This will only be used if DYNAMICPARTITIONCONVERT is set to true but right now the map is always populated. It will be good to explicitly populate the map (may be by a call from genConversionSelectOperator before adding the cast) ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java Lines 222 (patched) <https://reviews.apache.org/r/72063/#comment307709> A comment would be helpful here to explain why we need to keep it ql/src/test/queries/clientpositive/dynpart_cast.q Lines 7 (patched) <https://reviews.apache.org/r/72063/#comment307710> Can we add explain plan? ql/src/test/results/clientpositive/dynpart_sort_optimization_acid2.q.out Lines 36 (patched) <https://reviews.apache.org/r/72063/#comment307711> This test is to test Sort dynamic bucket partitioning, with the change this optimization is not kicking in anymore (PARTITION_BUCKET_SORTED keyword is missing in File sink). We should understand why is it happening and may be either fix it or log a jira. - Vineet Garg On Jan. 30, 2020, 3:30 p.m., Karen Coppage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72063/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2020, 3:30 p.m.) > > > Review request for hive and Peter Vary. > > > Bugs: HIVE-10362 > https://issues.apache.org/jira/browse/HIVE-10362 > > > Repository: hive-git > > > Description > ------- > > Example: > create table dynparttypechecknum (key int, value string) partitioned by (part > int); > insert into dynparttypechecknum partition (part) select key, value, '00001' > from src limit 1; > show partitions dynparttypechecknum; > > Partition created will be named: > part=00001 > even though the type of `part` is int. > > Solution is to cast the inserted DP columns in the SelectOperator before > FileSinkOperator which creates the partition dir, not after. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 12a022c590 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > c2514eedb1 > ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicPartitionCtx.java > c1aeb8f136 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java > 2c4b69b2fe > ql/src/test/queries/clientpositive/dynpart_cast.q PRE-CREATION > ql/src/test/results/clientpositive/autoColumnStats_6.q.out da3be3e5bb > ql/src/test/results/clientpositive/dynpart_cast.q.out PRE-CREATION > ql/src/test/results/clientpositive/dynpart_sort_optimization_acid2.q.out > 43bb789840 > ql/src/test/results/clientpositive/infer_bucket_sort_num_buckets.q.out > f745b46899 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out > fc9050b2c3 > > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out > 95aae7286f > ql/src/test/results/clientpositive/llap/llap_smb.q.out 24026d0bab > ql/src/test/results/clientpositive/llap/orc_merge1.q.out 9da73e65ac > ql/src/test/results/clientpositive/llap/orc_merge10.q.out a6ea33493f > ql/src/test/results/clientpositive/llap/orc_merge2.q.out 9b0d3b4234 > ql/src/test/results/clientpositive/llap/orc_merge_diff_fs.q.out d35f44b10a > ql/src/test/results/clientpositive/llap/rcfile_merge2.q.out fcff20a68e > ql/src/test/results/clientpositive/llap/tez_dml.q.out 4ad78d8582 > ql/src/test/results/clientpositive/orc_merge1.q.out 9c07816340 > ql/src/test/results/clientpositive/orc_merge10.q.out 4a5f03c82f > ql/src/test/results/clientpositive/orc_merge2.q.out d132d62b18 > ql/src/test/results/clientpositive/orc_merge_diff_fs.q.out 7f9a04b09f > ql/src/test/results/clientpositive/smb_join_partition_key.q.out c18d01d26a > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out > bc6c3add54 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out_spark > 67b62c1265 > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_num_buckets.q.out > 56d5ed945b > ql/src/test/results/clientpositive/spark/orc_merge1.q.out 977c4cbfc1 > ql/src/test/results/clientpositive/spark/orc_merge2.q.out 4647b86ea3 > ql/src/test/results/clientpositive/spark/orc_merge_diff_fs.q.out b7d3dd725d > > > Diff: https://reviews.apache.org/r/72063/diff/2/ > > > Testing > ------- > > There were changes in query output in two spark auto_sortmerge_join_16.q.out > files. They now match the query output of llap/auto_sortmerge_join_16.q.out. > > > Thanks, > > Karen Coppage > >
