----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72105/#review219570 -----------------------------------------------------------
Ship it! Ship It! - Laszlo Pinter On Feb. 12, 2020, 3:23 p.m., Karen Coppage wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72105/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 3:23 p.m.) > > > Review request for hive and Laszlo Pinter. > > > Bugs: HIVE-22610 > https://issues.apache.org/jira/browse/HIVE-22610 > > > Repository: hive-git > > > Description > ------- > > Minor compaction for MM (insert-only) tables > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java > 4c01311 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestMmCompactorOnTez.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > bb70db4 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java > bad5d00 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmQueryCompactorUtils.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java > 2f2bb21 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java 88ca683 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommandsForMmTable.java > aabf15c > > > Diff: https://reviews.apache.org/r/72105/diff/2/ > > > Testing > ------- > > The 3 unit tests removed here are really 2 tests (one is a duplicate). > Insert-only minor compaction used to do nothing but remove aborted > directories; these 2 tests were written for this functionality specifically. > The unit tests added here cover that functionality as well as compaction, and > rendered the old unit tests obsolete. > > > Thanks, > > Karen Coppage > >