----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71962/ -----------------------------------------------------------
(Updated Feb. 15, 2020, 12:06 a.m.) Review request for hive and Raj Kumar. Repository: hive-git Description ------- For numeric value 0 (tinyint, smallint, int, bigint), the mask functions are not masking it correctly. It should be replaced as 'numberChat' if masked. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMask.java 27c3bf8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskFirstN.java 76ee292 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskLastN.java c0c5c61 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskShowFirstN.java a8f70f2 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMaskShowLastN.java c72d75e ql/src/test/queries/clientpositive/udf_mask.q 15f7d27 ql/src/test/queries/clientpositive/udf_mask_first_n.q 3cd3962 ql/src/test/queries/clientpositive/udf_mask_last_n.q 89eb05d ql/src/test/queries/clientpositive/udf_mask_show_first_n.q 1425a82 ql/src/test/queries/clientpositive/udf_mask_show_last_n.q c4d15fb ql/src/test/results/clientpositive/udf_mask.q.out ed01449 ql/src/test/results/clientpositive/udf_mask_first_n.q.out e33fb42 ql/src/test/results/clientpositive/udf_mask_last_n.q.out 07a254f ql/src/test/results/clientpositive/udf_mask_show_first_n.q.out 3ec3270 ql/src/test/results/clientpositive/udf_mask_show_last_n.q.out 4dd42fd Diff: https://reviews.apache.org/r/71962/diff/2/ Testing ------- Thanks, Quanlong Huang
