----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72109/#review219603 -----------------------------------------------------------
LGTM +1, just minor nits? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java Lines 97-98 (original), 95-96 (patched) <https://reviews.apache.org/r/72109/#comment307785> nit: Do we need these formatting changes? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java Line 107 (original), 105 (patched) <https://reviews.apache.org/r/72109/#comment307786> nit: Do we need these formatting changes? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java Line 131 (original), 129 (patched) <https://reviews.apache.org/r/72109/#comment307787> nit: Do we need these formatting changes? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java Line 136 (original), 134 (patched) <https://reviews.apache.org/r/72109/#comment307788> nit: Do we need these formatting changes? - Peter Vary On febr. 11, 2020, 10:24 de, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72109/ > ----------------------------------------------------------- > > (Updated febr. 11, 2020, 10:24 de) > > > Review request for hive, Karen Coppage, Marta Kuczora, and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-20948: Eliminate file rename in compactor > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > 9ad4e7148226b91b0c759de54e251893d61725a3 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java > 076b77877ae748b757a4c9c08532a3ce029fed38 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > 2f5ec5270c0bc7d1a591c9c8c15b1ecb7f9f6ace > ql/src/java/org/apache/hadoop/hive/ql/plan/FileSinkDesc.java > ecc7bdee4dacc03cf59ac5be4bed92a75f8e720b > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > bb70db452402dd690e2136a122e9b3bd11fa7522 > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java > f238eb5dd058fc79c5b7ad3b08920c774b1a7f8c > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java > f96a0481b870b04cc97621cd62a43b07ecd5d7fd > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java > d2349104902c2af3d6020c9599fd3fa20f9a64a5 > > > Diff: https://reviews.apache.org/r/72109/diff/2/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
