----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72200/#review219806 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line 2421 (original), 2421 (patched) <https://reviews.apache.org/r/72200/#comment308037> i think we shall check for atleast 100K rows before turning this off, so checking for 10K batches make more sense to me. So, lets have default as 10K here. - Ashutosh Chauhan On March 5, 2020, 2:22 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72200/ > ----------------------------------------------------------- > > (Updated March 5, 2020, 2:22 p.m.) > > > Review request for hive, Gopal V, Jesús Camacho Rodríguez, Krisztian Kasa, > and Rajesh Balamohan. > > > Bugs: HIVE-22982 > https://issues.apache.org/jira/browse/HIVE-22982 > > > Repository: hive-git > > > Description > ------- > > The check is triggered after every n batches but there can be multiple > filters, one for each partition. Some filters might have less data then the > others. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7ea2de9019c > ql/src/java/org/apache/hadoop/hive/ql/exec/TopNKeyOperator.java f09867bb4e8 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorTopNKeyOperator.java > 0f8eb173c66 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestTopNKeyFilter.java > a91bc7354a7 > > > Diff: https://reviews.apache.org/r/72200/diff/1/ > > > Testing > ------- > > manually > > > Thanks, > > Attila Magyar > >
