[jira] [Created] (HIVE-23098) Allow Operation assertState to Accept a Collection

[David Mollitor (Jira)]

David Mollitor created HIVE-23098:
-------------------------------------

             Summary: Allow Operation assertState to Accept a Collection
                 Key: HIVE-23098
                 URL: https://issues.apache.org/jira/browse/HIVE-23098
             Project: Hive
          Issue Type: Improvement
            Reporter: David Mollitor
            Assignee: David Mollitor
         Attachments: HIVE-23098.1.patch

{code:java|title=Operation.java}
  protected final void assertState(List<OperationState> states) throws 
HiveSQLException {
    if (!states.contains(state)) {
      throw new HiveSQLException("Expected states: " + states.toString() + ", 
but found "
          + this.state);
    }
    this.lastAccessTime = System.currentTimeMillis();
  }
/*********************/
public void someMethod() {
    assertState(new 
ArrayList<OperationState>(Arrays.asList(OperationState.FINISHED)));
}
{code}

By allowing {{assertState}} to accept a {{Collection}}, one can save an 
allocation and simplify the code:

{code:java}
    assertState(Collections.singleton(OperationState.FINISHED));
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)