----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72264/#review220146 -----------------------------------------------------------
Thanks for the patch Marci! A few questions below, feel free to correct me if I am wrong - this was just a cursory review. Thanks, Peter standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 199 (patched) <https://reviews.apache.org/r/72264/#comment308468> %d could be problematic with different locales standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 2412 (patched) <https://reviews.apache.org/r/72264/#comment308469> nit: unnecessary move, might make backporting harder standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 2545 (patched) <https://reviews.apache.org/r/72264/#comment308470> Is it possible to collect the all of the data before starting the RDBMS query, and get all of the data for a enqueueLockRequest in one go? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 2599 (patched) <https://reviews.apache.org/r/72264/#comment308471> Do we need this? We do not commit temp lock id, so we can have just a single value which definitely will not appear in the table - Peter Vary On márc. 24, 2020, 2:24 du, Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72264/ > ----------------------------------------------------------- > > (Updated márc. 24, 2020, 2:24 du) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23052: Optimize lock enqueueing in TxnHandler > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java > f92ce7325e > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/DbCPDataSourceProvider.java > 85719fdf84 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > 76bbf3bc1e > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e > > > Diff: https://reviews.apache.org/r/72264/diff/2/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21249/ > Custom benchmark results attached to ticket: > https://issues.apache.org/jira/browse/HIVE-23052 > > > Thanks, > > Marton Bod > >
