----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/#review220212 -----------------------------------------------------------
Thanks for the patch @Zoltan! Some comments below. Peter standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Line 23 (original), 23 (patched) <https://reviews.apache.org/r/72112/#comment308516> Please avoid wildcard imports standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Line 31 (original), 29 (patched) <https://reviews.apache.org/r/72112/#comment308517> Please avoid wildcard imports standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Line 42 (original), 32 (patched) <https://reviews.apache.org/r/72112/#comment308518> Please avoid wildcard imports standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Lines 423-425 (patched) <https://reviews.apache.org/r/72112/#comment308519> Maybe not here, maybe in another jira, but check, measure and execute all of the HMS calls for a typical query (not sure that the names, and a list is entirely correct:) ) : - openTxn - getOpenTxns - getValidWriteIds - enqueueLock - commit/abort standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Lines 430 (patched) <https://reviews.apache.org/r/72112/#comment308520> Do we need this? Shouldn't the lock be unlocked by commitTnx? standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java Line 23 (original), 23 (patched) <https://reviews.apache.org/r/72112/#comment308522> wildcard import standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java Line 51 (original), 44 (patched) <https://reviews.apache.org/r/72112/#comment308521> wildcard import standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java Lines 341 (patched) <https://reviews.apache.org/r/72112/#comment308523> I put this in the code with HIVE-23042: boolean openTxn(int numTxns) throws TException { client.open_txns(new OpenTxnRequest(numTxns, "Test", "Host")); return true; } Maybe merge those? standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java Line 24 (original), 24 (patched) <https://reviews.apache.org/r/72112/#comment308524> wildcard import standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java Line 40 (original), 35 (patched) <https://reviews.apache.org/r/72112/#comment308525> wildcard import - Peter Vary On ápr. 2, 2020, 2:13 du, Zoltan Chovan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72112/ > ----------------------------------------------------------- > > (Updated ápr. 2, 2020, 2:13 du) > > > Review request for hive, Denys Kuzmenko, Aron Hamvas, Marton Bod, and Peter > Vary. > > > Repository: hive-git > > > Description > ------- > > Add the possibility to run benchmarks on opening lock in the HMS. Currently > this change only introduces single-threaded/single client testing. I'm > planning to add multi-client support in a separate change. > > Example parametrisation is as follows: > hbench -M "lock" -N 10 -d hive_test -W 0 -L 100 > hbench -M ".*Lock.*" -N 10 -d hive_test -W 0 -L 100 -T 8 --params 100 > > This will create N number (10) of tables to lock and it'll execute the lock() > for L number (100) of times on T (8) threads where each thread will strart an > HMS client > > > Diffs > ----- > > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/BenchmarkTool.java > 041cd76234 > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java > f53f2ef43b > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java > 7cc1e42a8b > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java > 101d6759c5 > > > Diff: https://reviews.apache.org/r/72112/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-22869.2.patch > > https://reviews.apache.org/media/uploaded/files/2020/04/02/5e35e835-f383-495f-9964-e66773fd6a90__HIVE-22869.2.patch > > > Thanks, > > Zoltan Chovan > >
