----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/ -----------------------------------------------------------
(Updated April 6, 2020, 10:04 a.m.) Review request for hive and Adam Szita. Repository: hive-git Description ------- KILL <queryId|querytag> command was implemented in: https://issues.apache.org/jira/browse/HIVE-17483 https://issues.apache.org/jira/browse/HIVE-20549 But it is not working in an environment where service discovery is enabled and more than one HS2 instance is running (except for manually sending the kill query to all HS2 instance). Solution: If a HS2 instance can't kill a query locally, it should post a kill query request to the Zookeeper Every HS2 should watch the Zookeeper for kill query requests and if its running on that instance kill it Authorization of kill query should work the same Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 73f185a1f3 itests/hive-unit/src/test/java/org/apache/hive/jdbc/BaseJdbcWithMiniLlap.java 3973ec9270 itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniLlapArrow.java 68a515ccbe itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithServiceDiscovery.java PRE-CREATION itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/TestMiniHS2StateWithNoZookeeper.java 99e681e5b2 itests/hive-unit/src/test/java/org/apache/hive/service/server/TestKillQueryZookeeperManager.java PRE-CREATION itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java 1b60a51ebd jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java db965e7a22 ql/src/java/org/apache/hadoop/hive/ql/ddl/process/kill/KillQueriesOperation.java afde1a4762 ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 8becef1cd3 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 9e497545b5 service/src/java/org/apache/hive/service/cli/session/SessionManager.java 277519cba5 service/src/java/org/apache/hive/service/server/HiveServer2.java 181ea5d6d5 service/src/java/org/apache/hive/service/server/KillQueryImpl.java 883e32bd2e service/src/java/org/apache/hive/service/server/KillQueryZookeeperManager.java PRE-CREATION standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/ZooKeeperHiveHelper.java 71d8651712 Diff: https://reviews.apache.org/r/72276/diff/3/ Changes: https://reviews.apache.org/r/72276/diff/2-3/ Testing ------- Thanks, Peter Varga
