> On April 8, 2020, 3:23 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java > > Line 60 (original), 60 (patched) > > <https://reviews.apache.org/r/72324/diff/3/?file=2217221#file2217221line60> > > > > add builder for ExclWrite
added > On April 8, 2020, 3:23 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/LockTypeUtil.java > > Lines 14 (patched) > > <https://reviews.apache.org/r/72324/diff/3/?file=2217225#file2217225line14> > > > > why not enum? That was my initial approach too, but in the end, having a second enum required lots of mapping between the two enums, and both having the same value set caused quite a bit of duplication too. I think by using this util class, we can more cleanly extend the LockType enum with any necessary state and behaviour, without introducing duplication. > On April 8, 2020, 3:23 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/LockTypeUtil.java > > Lines 34 (patched) > > <https://reviews.apache.org/r/72324/diff/3/?file=2217225#file2217225line34> > > > > you can move inverse into static and do no calc every time good spot, fixed - Marton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72324/#review220258 ----------------------------------------------------------- On April 8, 2020, 3:09 p.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72324/ > ----------------------------------------------------------- > > (Updated April 8, 2020, 3:09 p.m.) > > > Review request for hive, Denys Kuzmenko, Peter Vary, and Zoltan Chovan. > > > Repository: hive-git > > > Description > ------- > > HIVE-22750: Consolidate LockType naming > > > Diffs > ----- > > > hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java > e249b7775e > > hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java > 52eb6133e7 > metastore/scripts/upgrade/hive/hive-schema-4.0.0.hive.sql 03540bba4d > metastore/scripts/upgrade/hive/upgrade-3.1.0-to-4.0.0.hive.sql fa518747de > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 17e6cdf162 > ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java > 72f095d264 > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > 80fb1aff78 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockType.java > 8ae4351129 > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > db4cfb996a > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > cf3137928f > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > 849970eb56 > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java > c739d4d196 > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 098ddec5dc > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 7d0db0c3a0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > da38a6bbd3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/LockTypeUtil.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTxns.java > 1dfc105958 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/LockTypeUtilTest.java > PRE-CREATION > streaming/src/java/org/apache/hive/streaming/TransactionBatch.java > d44065018f > > > Diff: https://reviews.apache.org/r/72324/diff/3/ > > > Testing > ------- > > > Thanks, > > Marton Bod > >
