> On April 14, 2020, 11:22 a.m., Peter Vary wrote: > > Thanks for the patch Marton! > > Some questions, ideas. > > > > Thanks, > > Peter
Thanks for the review Peter! See my answers below and the updated diff > On April 14, 2020, 11:22 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Line 1248 (original), 1228 (patched) > > <https://reviews.apache.org/r/72359/diff/1/?file=2217523#file2217523line1267> > > > > Is this 'rs' not reused later? Maybe use a local scoped rs here? No, it's not reused anymore. I've made it locally-scoped. > On April 14, 2020, 11:22 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1325 (patched) > > <https://reviews.apache.org/r/72359/diff/1/?file=2217523#file2217523line1388> > > > > Not really important since this is a private method, but why not return > > boolean instead? Would be nice, but we need the ResultSet to log out the details of what exact conflict has been found. > On April 14, 2020, 11:22 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1351 (patched) > > <https://reviews.apache.org/r/72359/diff/1/?file=2217523#file2217523line1414> > > > > Maybe log the query in debug level? Sure > On April 14, 2020, 11:22 a.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1375 (patched) > > <https://reviews.apache.org/r/72359/diff/1/?file=2217523#file2217523line1438> > > > > Might worth to initialize with a size Done - Marton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72359/#review220308 ----------------------------------------------------------- On April 14, 2020, 8:57 a.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72359/ > ----------------------------------------------------------- > > (Updated April 14, 2020, 8:57 a.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23104: Minimize critical paths of TxnHandler::commitTxn and abortTxn > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 7d0db0c3a0 > > > Diff: https://reviews.apache.org/r/72359/diff/1/ > > > Testing > ------- > > Green build: > https://builds.apache.org/job/PreCommit-HIVE-Build/21539/testReport > Benchmark results attached to ticket: > https://issues.apache.org/jira/browse/HIVE-23104 > > > Thanks, > > Marton Bod > >
