----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72378/#review220389 -----------------------------------------------------------
LGTM, just number of comments ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java Lines 143 (patched) <https://reviews.apache.org/r/72378/#comment308753> Maybe use log.error here? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2413 (original), 2423 (patched) <https://reviews.apache.org/r/72378/#comment308754> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2438 (original), 2449 (patched) <https://reviews.apache.org/r/72378/#comment308755> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2633 (original), 2644 (patched) <https://reviews.apache.org/r/72378/#comment308756> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2679 (original), 2692 (patched) <https://reviews.apache.org/r/72378/#comment308758> what's the benefit of this? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2693 (original), 2707 (patched) <https://reviews.apache.org/r/72378/#comment308757> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2747 (original), 2761 (patched) <https://reviews.apache.org/r/72378/#comment308759> What's the benefit of this? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 2773 (original), 2787 (patched) <https://reviews.apache.org/r/72378/#comment308760> log.error, start with capitalized standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Lines 4427 (patched) <https://reviews.apache.org/r/72378/#comment308761> I would keep as it was before. no need to modify the query standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4458 (original), 4476 (patched) <https://reviews.apache.org/r/72378/#comment308762> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4481 (original), 4492 (patched) <https://reviews.apache.org/r/72378/#comment308763> What's the purpose of this? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4502 (original), 4513 (patched) <https://reviews.apache.org/r/72378/#comment308764> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4527 (original), 4536 (patched) <https://reviews.apache.org/r/72378/#comment308766> log.error standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4717 (original), 4726 (patched) <https://reviews.apache.org/r/72378/#comment308769> Why not Prepared statement? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4728 (original), 4731 (patched) <https://reviews.apache.org/r/72378/#comment308768> could we use Optional here? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4742 (original), 4742 (patched) <https://reviews.apache.org/r/72378/#comment308770> Why not Prepared statement? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4771 (original), 4764 (patched) <https://reviews.apache.org/r/72378/#comment308771> Why not Prepared statement? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4809 (original), 4799 (patched) <https://reviews.apache.org/r/72378/#comment308772> I would refrase like Deleted {} locks due to timed-out. Lock ids: {} standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java Line 4817 (original), 4804 (patched) <https://reviews.apache.org/r/72378/#comment308773> Do we need "due to" if we supply exception. - Denys Kuzmenko On April 17, 2020, 11:30 a.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72378/ > ----------------------------------------------------------- > > (Updated April 17, 2020, 11:30 a.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23201: Improve logging in locking > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java 4b6bc3e1e3 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > d080df417b > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > b3a1f826bb > > > Diff: https://reviews.apache.org/r/72378/diff/2/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21717/ > > > Thanks, > > Marton Bod > >
