> On May 8, 2020, 12:13 p.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/ShowTableStatusOperation.java > > Line 63 (original), 63 (patched) > > <https://reviews.apache.org/r/72483/diff/1/?file=2230664#file2230664line64> > > > > seems like earlier the filtering was done on the metastore side? > > in case directsql is on it will collect all tablenames using a simple > > sql stmt...so I think this might be ok.
Yes, unfortunately the output of UDFLike.likePatternToRegExp is not acceptable for datanucleus's match like, as it is not supporting the full spectrum of the java Pattern syntax. > On May 8, 2020, 12:13 p.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ddl/view/show/ShowViewsOperation.java > > Line 56 (original), 63 (patched) > > <https://reviews.apache.org/r/72483/diff/1/?file=2230667#file2230667line67> > > > > note: at this point viewNames is already sorted...treeset is redundant > > here Correct, I'll remove it. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72483/#review220691 ----------------------------------------------------------- On May 7, 2020, 11:16 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72483/ > ----------------------------------------------------------- > > (Updated May 7, 2020, 11:16 a.m.) > > > Review request for hive and Zoltan Haindrich. > > > Bugs: HIVE-23359 > https://issues.apache.org/jira/browse/HIVE-23359 > > > Repository: hive-git > > > Description > ------- > > Follow the SQL conventions. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/ddl/database/show/ShowDatabasesOperation.java > 625a48ee71 > > ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/status/ShowTableStatusOperation.java > 914e63d80c > > ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/tables/ShowTablesOperation.java > 4846d2969c > > ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/show/ShowMaterializedViewsOperation.java > 792b352e4c > ql/src/java/org/apache/hadoop/hive/ql/ddl/view/show/ShowViewsOperation.java > 7962551cc9 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java f6a5207ddb > ql/src/test/queries/clientnegative/show_tablestatus.q 283b5836e2 > ql/src/test/queries/clientpositive/alter1.q 0843351996 > ql/src/test/queries/clientpositive/alter2.q 6586afca8f > ql/src/test/queries/clientpositive/alter3.q a38643de41 > ql/src/test/queries/clientpositive/alter4.q 7a87113edc > ql/src/test/queries/clientpositive/alter5.q 5abd14f075 > ql/src/test/queries/clientpositive/create_view.q 392ebf4591 > ql/src/test/queries/clientpositive/describe_table_json.q 8aea7f283f > ql/src/test/queries/clientpositive/encryption_auto_purge_tables.q > 14c7f7eb96 > ql/src/test/queries/clientpositive/encryption_drop_table.q 884e510a92 > ql/src/test/queries/clientpositive/encryption_move_tbl.q b63607641a > ql/src/test/queries/clientpositive/input2.q c7b0d3024a > ql/src/test/queries/clientpositive/input3.q 07d75bdb29 > ql/src/test/queries/clientpositive/rename_column.q 82036f68b0 > ql/src/test/queries/clientpositive/show_materialized_views.q 81f86a7a95 > ql/src/test/queries/clientpositive/show_tables.q 8576daa689 > ql/src/test/queries/clientpositive/show_tablestatus.q d8f04ec30d > ql/src/test/queries/clientpositive/show_views.q 1af89b6d9e > ql/src/test/queries/clientpositive/temp_table_names.q bac26d3bf3 > ql/src/test/queries/clientpositive/temp_table_truncate.q 93a54d9f46 > ql/src/test/results/clientnegative/show_tablestatus.q.out ed962e7eca > ql/src/test/results/clientpositive/create_view.q.out 7414d4749d > > ql/src/test/results/clientpositive/encrypted/encryption_auto_purge_tables.q.out > 1d7707cc76 > ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out > 90ec23641f > ql/src/test/results/clientpositive/encrypted/encryption_move_tbl.q.out > ff3bda628c > ql/src/test/results/clientpositive/llap/alter1.q.out 1fef592df4 > ql/src/test/results/clientpositive/llap/alter2.q.out b9d1b6170a > ql/src/test/results/clientpositive/llap/alter3.q.out 7ceeb3af9c > ql/src/test/results/clientpositive/llap/alter4.q.out 74e2dfb6b6 > ql/src/test/results/clientpositive/llap/alter5.q.out 61a04f2702 > ql/src/test/results/clientpositive/llap/describe_table_json.q.out > cc33e6dccc > ql/src/test/results/clientpositive/llap/input2.q.out 28f7da4f02 > ql/src/test/results/clientpositive/llap/input3.q.out 0365ff25ba > ql/src/test/results/clientpositive/llap/rename_column.q.out 15816bbf98 > ql/src/test/results/clientpositive/llap/show_materialized_views.q.out > d377f97f14 > ql/src/test/results/clientpositive/llap/show_tables.q.out ade1690e89 > ql/src/test/results/clientpositive/llap/show_tablestatus.q.out f875778430 > ql/src/test/results/clientpositive/llap/show_views.q.out b5d2027420 > ql/src/test/results/clientpositive/llap/temp_table_names.q.out f8ad01a2d9 > ql/src/test/results/clientpositive/llap/temp_table_truncate.q.out > 20aeafc2db > > > Diff: https://reviews.apache.org/r/72483/diff/1/ > > > Testing > ------- > > Tests were modified to the new format. > > > Thanks, > > Miklos Gergely > >
