----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/ -----------------------------------------------------------
(Updated May 19, 2020, 5:58 a.m.) Review request for hive, Laszlo Pinter and Peter Vary. Changes ------- Patch 6 Bugs: HIVE-22971 https://issues.apache.org/jira/browse/HIVE-22971 Repository: hive-git Description ------- File rename is expensive for object stores, so MM (insert-only) compaction should skip that step when committing and write directly to base_x_cZ or delta_x_y_cZ. This also fixes the issue that for MM QB compaction the temp tables were stored under the table directory, and these temp dirs were never cleaned up. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f5ad3a882b7 itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java b9db1d1bb98 itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java 89920ccebf4 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 9410a963518 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MajorQueryCompactor.java c70d4f33a80 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MinorQueryCompactor.java 4d0e5f703e7 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMajorQueryCompactor.java 724a4375b75 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MmMinorQueryCompactor.java 1cd95f80155 ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java 7f3ccfa04ed ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactorFactory.java 6542eef58af Diff: https://reviews.apache.org/r/72281/diff/2/ Changes: https://reviews.apache.org/r/72281/diff/1-2/ Testing ------- Thanks, Karen Coppage