----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72929/ -----------------------------------------------------------
Review request for hive and David Mollitor. Bugs: HIVE-24184 https://issues.apache.org/jira/browse/HIVE-24184 Repository: hive-git Description ------- Driver is still a huge class, with a lot of methods. They are not representing the order of the process done by the Driver (compilation, execution, result providing, closing). Also the constructors are not at the beginning of the class. All of these make the class harder to read. By re-ordering them it would be easier. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/Driver.java c4517fa15e Diff: https://reviews.apache.org/r/72929/diff/1/ Testing ------- All the tests are still passing. Thanks, Miklos Gergely