[
https://issues.apache.org/jira/browse/HIVE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2720:
------------------------------
Attachment: HIVE-2720.D1299.1.patch
enis requested code review of "HIVE-2720 [jira] Merge MetaStoreListener and
HiveMetaHook interfaces".
Reviewers: JIRA
HIVE-2720. Merge MetaStoreListener and HiveMetaHook interfaces. First version
of the patch
MetaStoreListener and HiveMetaHook both serve as a notification mechanism for
metastore-related events. The former is used by hcat and the latter is by the
hbase-storage handler, and invoked by the client.
I propose to merge these interfaces, and extend the MetaStoreListener, to add
most of the on- and pre- methods at the Thrift interface. This way, extending
metastore will be easier, and validation, storage-driver notification, and
enforcement can be delegated to individual listeners. Besides, more
functionality can be plugged-in by Hcat at this level.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1299
AFFECTED FILES
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaHookLoader.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListenerLoader.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java
ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultStorageHandler.java
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2703/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Merge MetaStoreListener and HiveMetaHook interfaces
> ---------------------------------------------------
>
> Key: HIVE-2720
> URL: https://issues.apache.org/jira/browse/HIVE-2720
> Project: Hive
> Issue Type: Sub-task
> Components: JDBC, Metastore, ODBC, Security
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HIVE-2720.D1299.1.patch
>
>
> MetaStoreListener and HiveMetaHook both serve as a notification mechanism for
> metastore-related events. The former is used by hcat and the latter is by the
> hbase-storage handler, and invoked by the client.
> I propose to merge these interfaces, and extend the MetaStoreListener, to add
> most of the on- and pre- methods at the Thrift interface. This way, extending
> metastore will be easier, and validation, storage-driver notification, and
> enforcement can be delegated to individual listeners. Besides, more
> functionality can be plugged-in by Hcat at this level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
