[
https://issues.apache.org/jira/browse/HIVE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2261:
------------------------------
Attachment: HIVE-2261.D1329.1.patch
navis requested code review of "HIVE-2261 [jira] Add cleanup stages for UDFs".
Reviewers: JIRA
DPAL-19 Add cleanup stages for UDFs
In some cases, we bind values at last stage of big SQL from other sources,
especially from memcached. I made that kind of UDFs for internal-use.
I found 'initialize' method of GenericUDF class is good place for making
connections to memcached cluster, but failed to find somewhere to
close/cleanup the connections. If there is cleaup method in GenericUDF class,
things can be more neat. If initializing entity like map/reduce/fetch could be
also providable to life-cycles(init/close), that makes perfect.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1329
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ExtractOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java
ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java
ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2757/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add cleanup stages for UDFs
> ---------------------------
>
> Key: HIVE-2261
> URL: https://issues.apache.org/jira/browse/HIVE-2261
> Project: Hive
> Issue Type: Wish
> Components: Query Processor
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: HIVE-2261.D1329.1.patch
>
>
> In some cases, we bind values at last stage of big SQL from other sources,
> especially from memcached. I made that kind of UDFs for internal-use.
> I found 'initialize' method of GenericUDF class is good place for making
> connections to memcached cluster, but failed to find somewhere to
> close/cleanup the connections. If there is cleaup method in GenericUDF class,
> things can be more neat. If initializing entity like map/reduce/fetch could
> be also providable to life-cycles(init/close), that makes perfect.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
