[ 
https://issues.apache.org/jira/browse/HIVE-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190022#comment-13190022
 ] 

Phabricator commented on HIVE-2589:
-----------------------------------

cwsteinbach has requested changes to the revision "HIVE-2589 [jira] Newly 
created partition should inherit properties from table".

INLINE COMMENTS
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:1574 
The description in hive-default.xml.template should mention that '*' denotes 
that all table properties will be inherited by new partitions.
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:1569 
Please add a comment at the beginning of this block: "// Inherit table 
properties"
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java:363 Thanks for tracking 
this down!
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:122 I'm not sure 
this belongs here. Do you really want the metastore to get reinitialized every 
time someone resets this configuration property?
  ql/src/test/queries/clientpositive/part_inherit_tbl_props_empty.q:1 
Explicitly set the configuration property to "" just to make things clear.

REVISION DETAIL
  https://reviews.facebook.net/D1335

                
> Newly created partition should inherit properties from table
> ------------------------------------------------------------
>
>                 Key: HIVE-2589
>                 URL: https://issues.apache.org/jira/browse/HIVE-2589
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.8.1, 0.9.0
>
>         Attachments: HIVE-2589.D1335.1.patch, hive-2589.patch, 
> hive-2589.patch, hive-2589_1.patch, hive-2589_2.patch, hive-2589_3.patch, 
> hive-2589_4.patch
>
>
> This will make all the info contained in table properties available to 
> partitions. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to