Stamatis Zampetakis created HIVE-26014:
------------------------------------------

             Summary: Remove redundant HushableRandomAccessFileAppender
                 Key: HIVE-26014
                 URL: https://issues.apache.org/jira/browse/HIVE-26014
             Project: Hive
          Issue Type: Improvement
          Components: HiveServer2
            Reporter: Stamatis Zampetakis
            Assignee: Stamatis Zampetakis


[HushableRandomAccessFileAppender|https://github.com/apache/hive/blob/d3cd596aa15ebedd58f99628d43a03eb2f5f3909/ql/src/java/org/apache/hadoop/hive/ql/log/HushableRandomAccessFileAppender.java]
 was introduced by HIVE-17826 to avoid exceptions originating from attempts to 
write to a closed appender.

After the changes in HIVE-24590, the life-cycle (opening/closing/deleting) of 
appenders is managed by the Log4j framework and not explicitly by Hive as it 
used to be before. With HIVE-24590 in place, it is no longer possible to have 
the exception in HIVE-17826 cause appenders are opened and closed when 
necessary. 

Due to the above, the {{HushableRandomAccessFileAppender}} is completely 
redundant and can be removed in favor of the {{RandomAccessFileAppender}} 
already provided by the Log4j framework.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to