+1 (non-binding)

* Verified all checksums.
* Verified all signatures.
* Built from source.
    * mvn clean install -Piceberg -DskipTests
* Tests passed.
    * mvn --fail-never clean verify -Piceberg -Pitests
-Dmaven.test.jvm.args='-Xmx2048m -DJETTY_AVAILABLE_PROCESSORS=4'

BTW, gentle reminder: if someone would consider reviewing HIVE-26677, then
it would simplify verification on high-core machines, so that we wouldn't
need to remember to set -DJETTY_AVAILABLE_PROCESSORS.

https://github.com/apache/hive/pull/3713

Denys, thank you for driving the release.

Chris Nauroth


On Fri, Nov 11, 2022 at 9:33 AM Stamatis Zampetakis <zabe...@gmail.com>
wrote:

> +1 (non-binding)
>
> Ubuntu 20.04.5 LTS, java version "1.8.0_261", Apache Maven 3.6.3
>
> * Verified signatures and checksums OK
> * Checked diff between git repo and release sources (diff -qr hive-git
> hive-src) OK
> * Checked LICENSE, NOTICE, and README.md file OK
> * Built from release sources (mvn clean install -DskipTests -Pitests) OK
> * Package binaries from release sources (mvn clean package -DskipTests) OK
> * Built from git tag (mvn clean install -DskipTests -Pitests) OK
> * Run smoke tests on pseudo cluster using hive-dev-box [1] OK
> * Spot check maven artifacts for general structure, LICENSE, NOTICE,
> META-INF content OK
>
> Smoke tests included: * Derby metastore initialization * simple CREATE
> TABLE statements (TPCH Orders, Lineitem tables); * basic LOAD FROM LOCAL
> statements; * basic SELECT statements with simple INNER JOIN, WHERE, and
> GROUP BY variations; * EXPLAIN statement variations; * ANALYZE TABLE
> variations;
>
> While checking some of the maven artifacts I noticed
> that hive-exec-4.0.0-alpha-2.jar had two NOTICE files under META-INF
> (NOTICE.txt for Apache Commons Lang). Not blocking but maybe we should
> check/fix this in the next release.
>
> Best,
> Stamatis
>
> [1] https://lists.apache.org/thread/7yqs7o6ncpottqx8txt0dtt9858ypsbb
>
> On Fri, Nov 11, 2022 at 5:51 PM Naveen Gangam <ngan...@cloudera.com.invalid
> >
> wrote:
>
> > Hi Denys,
> > Thank you for publishing the release bits.
> >
> > *SIGNATURE VERIFICATION*
> >
> > gpg --verify apache-hive-4.0.0-alpha-2-bin.tar.gz.asc
> > apache-hive-4.0.0-alpha-2-bin.tar.gz
> >
> > gpg: Signature made Mon Nov  7 13:04:05 2022 EST
> >
> > gpg:                using RSA key
> 50606DE1BDBD5CF862A595A907C5682DAFC73125
> >
> > gpg:                issuer "dkuzme...@apache.org"
> >
> > gpg: Good signature from "Denys Kuzmenko (CODE SIGNING KEY) <
> > dkuzme...@apache.org>" [unknown]
> >
> > gpg: WARNING: The key's User ID is not certified with a trusted
> signature!
> >
> > gpg:          There is no indication that the signature belongs to the
> > owner.
> >
> > Primary key fingerprint: 5060 6DE1 BDBD 5CF8 62A5  95A9 07C5 682D AFC7
> 3125
> >
> >
> > $ gpg --verify apache-hive-4.0.0-alpha-2-src.tar.gz.asc
> > apache-hive-4.0.0-alpha-2-src.tar.gz
> >
> > gpg: Signature made Mon Nov  7 13:04:25 2022 EST
> >
> > gpg:                using RSA key
> 50606DE1BDBD5CF862A595A907C5682DAFC73125
> >
> > gpg:                issuer "dkuzme...@apache.org"
> >
> > gpg: Good signature from "Denys Kuzmenko (CODE SIGNING KEY) <
> > dkuzme...@apache.org>" [unknown]
> >
> > gpg: WARNING: The key's User ID is not certified with a trusted
> signature!
> >
> > gpg:          There is no indication that the signature belongs to the
> > owner.
> >
> > Primary key fingerprint: 5060 6DE1 BDBD 5CF8 62A5  95A9 07C5 682D AFC7
> 3125
> >
> >
> > shasum -a 256 -c apache-hive-4.0.0-alpha-2-src.tar.gz.sha256
> >
> > apache-hive-4.0.0-alpha-2-src.tar.gz: OK
> >
> >
> > $ shasum -a 256 -c apache-hive-4.0.0-alpha-2-bin.tar.gz.sha256
> >
> > apache-hive-4.0.0-alpha-2-bin.tar.gz: OK
> >
> >
> >
> > *BUILD VERIFICATION:*
> >
> >
> >    - From the source attachment, I was able to build using "mvn clean
> >    install -DskipTests -Pitests"
> >    - I also build from the git tag created for the release.
> >
> >
> > *CHECKIN TESTS --> I think these tests are flaky*
> >
> > [*INFO*] Running org.apache.hadoop.hive.metastore.client.*TestCatalogs*
> >
> > [*WARNING*] *Tests **run: 18*, Failures: 0, Errors: 0, *Skipped: 2*, Time
> > elapsed: 4.342 s - in
> > org.apache.hadoop.hive.metastore.client.*TestCatalogs*
> >
> > [*INFO*] Running org.apache.hadoop.hive.metastore.*TestMarkPartition*
> >
> > [*INFO*] *Tests run: 1*, Failures: 0, Errors: 0, Skipped: 0, Time
> elapsed:
> > 14.895 s - in org.apache.hadoop.hive.metastore.*TestMarkPartition*
> >
> > [*INFO*]
> >
> > [*INFO*] Results:
> >
> > [*INFO*]
> >
> > [*ERROR*] *Errors: *
> >
> > [*ERROR*] *  TestMysql.install » Runtime Unable to start docker
> container*
> >
> > [*ERROR*] *  TestMysql.upgrade » Runtime Unable to start docker
> container*
> >
> > [*ERROR*] *  TestOracle.install » Runtime Unable to start docker
> container*
> >
> > [*ERROR*] *  TestOracle.upgrade » Runtime Failed to get docker logs*
> >
> > [*INFO*]
> >
> > [*ERROR*] *Tests run: 2259, Failures: 0, Errors: 4, Skipped: 5*
> >
> > [*INFO*]
> >
> > [*INFO*]
> >
> *------------------------------------------------------------------------*
> >
> > [*INFO*] *BUILD FAILURE*
> >
> > [*INFO*]
> >
> *------------------------------------------------------------------------*
> >
> > [*INFO*] Total time:  25:20 min
> >
> > [*INFO*] Finished at: 2022-11-10T15:40:36-05:00
> >
> > [*INFO*]
> >
> *------------------------------------------------------------------------*
> >
> >
> > *RUNTIME*
> >
> > Started services from the binaries published (using local hadoop 3.1.0)
> >
> >
> >    - Installed schema for derby
> >    - started HS2 + HMS
> >    - Ran queries from beeline (DDL and DML)
> >    - Explain queries
> >    - CTAS queries.
> >
> >
> > +1 for me.
> >
> >
> > On Mon, Nov 7, 2022 at 2:00 PM Denys Kuzmenko
> > <dkuzme...@cloudera.com.invalid> wrote:
> >
> > > UPD: Voting will conclude in 1 week (Monday 14th).
> > >
> > >
> > > On Mon, Nov 7, 2022 at 7:57 PM Denys Kuzmenko <dkuzme...@cloudera.com>
> > > wrote:
> > >
> > > > Hi team,
> > > >
> > > > Let's give it 1 more chance.
> > > >
> > > > Apache Hive 4.0.0-alpha-2 Release Candidate 1 is available here:
> > > https://people.apache.org/~dkuzmenko/release-4.0.0-alpha-2-rc1/
> > > >
> > > >
> > > > Change log:
> > > >
> > > > - Updated copyright notices (year of distribution was taken from
> > > `project.build.outputTimestamp` defined in apache root pom)
> > > >
> > > > - javadoc artifacts included in maven staging repo
> > > >
> > > >
> > > > The checksums are these:
> > > > - f94c773e7ae3328d780138d9259c584e94d8f2e34715776cdfaaa78bcf3f25e1
> > > apache-hive-4.0.0-alpha-2-bin.tar.gz
> > > > - 02dbc19f007cb87e725713c67f69836b3efb8ffeb1562aac1f9c869e4429cc36
> > > apache-hive-4.0.0-alpha-2-src.tar.gz
> > > >
> > > >
> > > > Maven artifacts are available here:
> > > https://repository.apache.org/content/repositories/orgapachehive-1118/
> > > >
> > > > The tag release-4.0.0-alpha-2-rc1 has been created for this RC, you
> can
> > > find it at
> > > > https://github.com/apache/hive/tree/release-4.0.0-alpha-2-rc1
> > > >
> > > > The git commit hash is:
> > >
> >
> https://github.com/apache/hive/commit/36f5d91acb0fac00a5d46049bd45b744fe9aaab6
> > > >
> > > > Voting will conclude in 1 week (Monday 21th).
> > > >
> > > > Hive PMC Members: Please test and vote.
> > > >
> > > > Thanks,
> > > >
> > > > Denys
> > > >
> > > >
> > >
> >
>

Reply via email to