-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52912/#review225629
-----------------------------------------------------------


Ship it!




Ship It!

- Jude Dike


On Nov. 15, 2016, 11:13 p.m., Zoltan Haindrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52912/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 11:13 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and pengcheng xiong.
> 
> 
> Bugs: HIVE-13557
>     https://issues.apache.org/jira/browse/HIVE-13557
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> * added intervalExpression
> * moved intervalLiteral into intervalExpression
> * added days/months/seconds/years
> * moved interval support into an udf, this way: it may accept column refs or 
> expressions as input (sql2011)
> 
> supported:
> 
> * 1 day
> * interval 1 day
> * (1+x) day
> * interval (1+x) day
> * '1-1' year to month
> * interval '1-1' year to month
> * interval ('1-' || x) year to month
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
> 0dbbc1d6226330bcb8271abba8b2675adaeb6f0f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 
> 4357328c48dd721d02773557ad01e4ee572d6dd1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 
> a82083be94b8ca7875c84f78a365fa12ba0f033f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
> 5e708d3876cbe4bf14384b1798770311ae86401e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInternalInterval.java
>  PRE-CREATION 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/TestParseDriverIntervals.java 
> PRE-CREATION 
>   
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFInternalInterval.java
>  PRE-CREATION 
>   ql/src/test/queries/clientpositive/interval_alt.q PRE-CREATION 
>   ql/src/test/results/clientpositive/interval_alt.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 
> d8003baa5fa2ed0410d98d124ebf9bcee095598e 
>   ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 
> 13a8b356cc1825fec2cdd4731040dd025c42dc54 
>   ql/src/test/results/clientpositive/show_functions.q.out 
> d2f3b97add4563b97a5f581efd6a0295a9a7db56 
>   ql/src/test/results/clientpositive/vector_interval_1.q.out 
> 373a6dec223be9c8257cdfeca2acb641426c13b5 
>   ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 
> ff16b3b62372f530ed570b5728c8ca06bfab6b98 
> 
> 
> Diff: https://reviews.apache.org/r/52912/diff/2/
> 
> 
> Testing
> -------
> 
> * small test to check parsable formats
> * small unit test to check exceptions
> * added qtest for use case tests
> 
> 
> Thanks,
> 
> Zoltan Haindrich
> 
>

Reply via email to