Hello, Indeed they have an impact on the readability and maintenance of the class so I would be in favor of dropping them. Checking the calls to HiveConf.ConfVars#getDescription [1] it seems that line breaks are somewhat relevant for generating the hive-default.xml.template and SHOW CONF command but definitely not a reason for keeping them. In fact, I get the impression that by removing the line breaks we could also remove the respective normalization code.
Best, Stamatis https://github.com/apache/hive/blob/5b76949da6fe65364a4e3766680871167131157f/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java#L5899 On Sun, Feb 11, 2024 at 9:10 AM László Bodor <bodorlaszlo0...@gmail.com> wrote: > > Hey All! > > Maybe I'm missing some history here: does anyone know why and for what we > use line break characters in the descriptions in HiveConf > <https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java>? > (1046 occurrences as we speak) > As far as I can tell according to its current state, we *don't* generate > this page from the class: > https://cwiki.apache.org/confluence/display/hive/configuration+properties > > Motivation: the pain when I rephrase a config description and not only I > have to break long lines (which is fine for code style) but I have to > change (add/remove) line breaks too. > > Regards, > Laszlo Bodor
