+1 (binding) myself. Thanks everyone! The vote passed with 3 binding votes (Rui, Szehon and Chao), and 2 non-binding votes from Cheng and Dongjoon. I'll proceed to publish the release as the next step.
Chao On Tue, May 7, 2024 at 12:45 PM Szehon Ho <szehon.apa...@gmail.com> wrote: > +1 (binding) > > - Checked checksums > - Built from source > - Create and query simple table > - It seems some basic query print an ugly warning, but still pass in the > end. Not sure if need to change some config. > > 0: jdbc:hive2://> insert into test select 1; > 24/05/07 12:40:34 [537b5f20-dd1a-4be6-af09-effa6d9d37a5 main]: ERROR > parse.CalcitePlanner: CBO failed, skipping CBO. > org.apache.hadoop.hive.ql.optimizer.calcite.CalciteSemanticException: > Unsupported > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genLogicalPlan(CalcitePlanner.java:3974) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.apply(CalcitePlanner.java:1315) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.apply(CalcitePlanner.java:1261) > ~[hive-exec-2.3.10.jar:2.3.10] > at org.apache.calcite.tools.Frameworks$1.apply(Frameworks.java:113) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.calcite.prepare.CalcitePrepareImpl.perform(CalcitePrepareImpl.java:997) > ~[hive-exec-2.3.10.jar:2.3.10] > at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:149) > ~[hive-exec-2.3.10.jar:2.3.10] > at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:106) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner.logicalPlan(CalcitePlanner.java:1069) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner.getOptimizedAST(CalcitePlanner.java:1085) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner.genOPTree(CalcitePlanner.java:364) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:11138) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.CalcitePlanner.analyzeInternal(CalcitePlanner.java:286) > ~[hive-exec-2.3.10.jar:2.3.10] > at > org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:258) > ~[hive-exec-2.3.10.jar:2.3.10] > at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:512) > ~[hive-exec-2.3.10.jar:2.3.10] > at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1317) > ~[hive-exec-2.3.10.jar:2.3.10] > at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1295) > ~[hive-exec-2.3.10.jar:2.3.10] > > Thanks > Szehon > > On Tue, May 7, 2024 at 1:11 AM Rui Li <li...@apache.org> wrote: > >> +1 (binding) >> >> - Built from source >> - Verified signature and checksum >> - Ran some basic SQL statements >> - Verified the fix made in https://github.com/apache/hive/pull/5204 >> >> Thanks Chao for driving this. >> >> On Tue, May 7, 2024 at 2:26 AM Dongjoon Hyun <dongj...@apache.org> wrote: >> >>> +1 (non-binding) >>> >>> Thank you so much all! >>> >>> Dongjoon. >>> >>> On 2024/05/06 13:57:09 Cheng Pan wrote: >>> > +1 (non-binding) >>> > >>> > Pass integration test with Apache Spark[1] and Apache Kyuubi[2]. >>> > >>> > [1] https://github.com/apache/spark/pull/45372 >>> > [2] https://github.com/apache/kyuubi/pull/6328 >>> > >>> > Thanks, >>> > Cheng Pan >>> > >>> > >>> > >>> >> >> >> -- >> Cheers, >> Rui Li >> >
