[
https://issues.apache.org/jira/browse/HIVE-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197320#comment-13197320
]
Phabricator commented on HIVE-123:
----------------------------------
hobbymanyp has commented on the revision "HIVE-123 [jira] refactor DDL code
(both DDLWork and DDLTask)".
According to the steps, I think i am using HIVE-123. Should I change it to
"arc diff --jira HIVE-123x" (instead of "arc diff --jira HIVE-123") ?
https://cwiki.apache.org/Hive/phabricatorcodereview.html
From a git checkout (e.g. from git clone git://github.com/apache/hive.git), a
typical usage sequence is as follows:
ant arc-setup
git checkout -b HIVE-123-dev-branch
edit some files to implement HIVE-123
git commit -a -m "initial description of how I have gone about making DDL
code suck less"
arc diff --jira HIVE-123
optionally, visit diff URL provided by Phabricator to do things like add
reviewers and CC's
REVISION DETAIL
https://reviews.facebook.net/D1485
> refactor DDL code (both DDLWork and DDLTask)
> --------------------------------------------
>
> Key: HIVE-123
> URL: https://issues.apache.org/jira/browse/HIVE-123
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Namit Jain
> Assignee: Ashutosh Chauhan
> Labels: cleanup, refactoring
> Attachments: HIVE-123.D1485.1.patch, hive-123.patch
>
>
> It might be good to break DDLTask into separate tasks. The abstract class
> DDLWork can have various subclasses:
> showTablesWork, DescribeTableWork etc. and a separate task for each of them.
> This will make them completely independent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
