[
https://issues.apache.org/jira/browse/HIVE-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200606#comment-13200606
]
Phabricator commented on HIVE-2771:
-----------------------------------
jsichi has commented on the revision "HIVE-2771 [jira] Add support for filter
pushdown for key ranges in hbase for keys of type string".
One thing to note is that if the filter implementation turns out to be too
loose (rather than too strict), tests may not notice it because in some cases
Hive currently redundantly applies the filter row-by-row on whatever comes back
from the scan. (I've added a line-specific comment above for one of those
cases.) So you might want to add some private logging just to make sure you've
got it right. I can't remember whether that's why I added the WhileMatchFilter
originally.
Also, note the comment in HBaseStorageHandler.decomposePredicate. Have you a
tested a case such as WHERE key > 20 and key < 30?
INLINE COMMENTS
hbase-handler/src/test/results/hbase_ppd_key_range.q.out:47 Note that here
Hive did not remove the redundant filter.
REVISION DETAIL
https://reviews.facebook.net/D1551
> Add support for filter pushdown for key ranges in hbase for keys of type
> string
> -------------------------------------------------------------------------------
>
> Key: HIVE-2771
> URL: https://issues.apache.org/jira/browse/HIVE-2771
> Project: Hive
> Issue Type: Sub-task
> Components: HBase Handler
> Affects Versions: 0.7.0, 0.7.1, 0.8.0, 0.8.1
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Attachments: HIVE-2771.D1551.1.patch
>
>
> This is a subtask of HIVE-1643
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
