Improve hooks run in Driver
---------------------------

                 Key: HIVE-2779
                 URL: https://issues.apache.org/jira/browse/HIVE-2779
             Project: Hive
          Issue Type: Improvement
            Reporter: Kevin Wilfong
            Assignee: Kevin Wilfong


There are some small improvements that can be made to the hooks which are run 
in the Driver:

1) The code to get hooks has been clearly just been copy+pasted for each of 
Pre/Post/OnFailure/SemanticAnalyzer hooks.  This code should be consolidated 
into a single method.

2) There is a lot more information available to SemanticAnalyzer hooks which 
ran after semantic analysis than to those that run before, such as inputs and 
outputs.  We should make some of this information available to those hooks, 
preferably through HiveSemanticAnalyzerHookContext, so that existing hooks 
aren't broken.

3) Currently, possibly unintentionally, hooks are initialized and run in the 
order they appear in the comma separated list that is the value of the 
configuration variable.  This is a useful property, we should add comments 
indicating this is desired and add a unit test to enforce it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to