[ https://issues.apache.org/jira/browse/HIVE-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2797: ------------------------------ Attachment: HIVE-2797.D1701.1.patch kevinwilfong requested code review of "HIVE-2797 [jira] Make the IP address of a Thrift client available to HMSHandler.". Reviewers: JIRA https://issues.apache.org/jira/browse/HIVE-2797 Created a new subclass of ThriftHiveMetastore.Processor which passes the IP address to the HMSHandler. Unsecure connections will use this processor. The IP address is stored in a thread local variable, so that multiple connections will each maintain there own IP address. Currently, in unsecured mode, metastore Thrift calls are, from the HMSHandler's point of view, anonymous. If we expose the IP address of the Thrift client to the HMSHandler from the Processor, this will help to give some context, in particular for audit logging, of where the call is coming from. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1701 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/TUGIBasedProcessor.java metastore/src/java/org/apache/hadoop/hive/metastore/TSetIpAddressProcessor.java metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3633/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > Make the IP address of a Thrift client available to HMSHandler. > --------------------------------------------------------------- > > Key: HIVE-2797 > URL: https://issues.apache.org/jira/browse/HIVE-2797 > Project: Hive > Issue Type: Improvement > Reporter: Kevin Wilfong > Attachments: HIVE-2797.D1701.1.patch > > > Currently, in unsecured mode, metastore Thrift calls are, from the > HMSHandler's point of view, anonymous. If we expose the IP address of the > Thrift client to the HMSHandler from the Processor, this will help to give > some context, in particular for audit logging, of where the call is coming > from. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira