[
https://issues.apache.org/jira/browse/HIVE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220546#comment-13220546
]
Phabricator commented on HIVE-2827:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2827 [jira] Implement
nullsafe equi-join".
Looks good overall. I will test and commit once the requested changes have
been applied. Thanks.
INLINE COMMENTS
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:412 I wanted to see
this included in HIVE-2810 since it sounded like it would take some time to
implement the fix for JOINs, and in the meantime I didn't want people to
accidentally use <=> in JOINs. However, since this patch implements correct
JOIN handling for <=>, I don't think it makes sense to provide the option of
disabling this. Please remove.
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java:50 Spelling:
s/jon/join/
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:1339 Please
remove.
ql/src/test/queries/clientpositive/join_nullsafe.q:4 please reference the
path using the appropriate test system property, e.g.
"${system:test.src.data.dir}/files/in8.txt"
REVISION DETAIL
https://reviews.facebook.net/D1971
BRANCH
DPAL-873
> Implement nullsafe equi-join
> ----------------------------
>
> Key: HIVE-2827
> URL: https://issues.apache.org/jira/browse/HIVE-2827
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Environment: ubuntu 10.04
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Attachments: HIVE-2827.D1971.1.patch, HIVE-2827.D1971.2.patch,
> HIVE-2827.D1971.3.patch, HIVE-2827.D1971.4.patch
>
>
> was part of HIVE-2810, but separated because it affected more classes than
> expected.
> {noformat}
> SELECT * FROM a JOIN b ON a.key <=> b.key
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
