[
https://issues.apache.org/jira/browse/HIVE-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2716:
------------------------------
Attachment: HIVE-2716.D2055.1.patch
kevinwilfong requested code review of "HIVE-2716 [jira] Move retry logic in
HiveMetaStore to a separe class".
Reviewers: JIRA
This fixes the issue where the implementation of RawStore was being
initialized in the metastore before the JDOConnectionURLHook was being called.
I moved some code around so that the RawStore implementation is initialized in
the RetryRawStore initialization after the hook is called. In addition, the
URL now needs to be updated in the thread local configuration instead of the
non-thread local one, as by the time the hook is now being called, the thread
local configuration has already been initialized based on the other.
In HIVE-1219, method retrying for raw store operation are introduced to
handle jdo operations more robustly. However, the abstraction for the RawStore
operations can be moved to a separate class implementing RawStore, which should
clean up the code base for HiveMetaStore.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2055
AFFECTED FILES
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java
metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingRawStore.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4407/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Move retry logic in HiveMetaStore to a separe class
> ---------------------------------------------------
>
> Key: HIVE-2716
> URL: https://issues.apache.org/jira/browse/HIVE-2716
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Affects Versions: 0.9.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.9.0
>
> Attachments: HIVE-2716.D1227.1.patch, HIVE-2716.D1227.2.patch,
> HIVE-2716.D1227.3.patch, HIVE-2716.D1227.4.patch, HIVE-2716.D2055.1.patch,
> HIVE-2716.patch
>
>
> In HIVE-1219, method retrying for raw store operation are introduced to
> handle jdo operations more robustly. However, the abstraction for the
> RawStore operations can be moved to a separate class implementing RawStore,
> which should clean up the code base for HiveMetaStore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
