[ https://issues.apache.org/jira/browse/HIVE-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221392#comment-13221392 ]
Phabricator commented on HIVE-2833: ----------------------------------- kevinwilfong has commented on the revision "HIVE-2833 [jira] Fix test failures caused by HIVE-2716". INLINE COMMENTS metastore/src/test/org/apache/hadoop/hive/metastore/DummyJdoConnectionUrlHook.java:33 It is used in the test method. I thought it made sense to keep them together. metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreConnectionUrlHook.java:32 A q file will test the entire stack from CLI to the db underlying the Object Store, so it is much more complete. In this case, I just wanted to target a very specific test. Also, I don't like to change tests other people have written unless there is a clear problem with the test. In case I miss something they wanted to test. REVISION DETAIL https://reviews.facebook.net/D2055 > Fix test failures caused by HIVE-2716 > ------------------------------------- > > Key: HIVE-2833 > URL: https://issues.apache.org/jira/browse/HIVE-2833 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: Carl Steinbach > Assignee: Kevin Wilfong > Attachments: HIVE-2716.D2055.1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira