[ https://issues.apache.org/jira/browse/HIVE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225441#comment-13225441 ]
Phabricator commented on HIVE-2838: ----------------------------------- kevinwilfong has requested changes to the revision "HIVE-2838 [jira] cleanup readentity/writeentity". The code looks good. Noticed a few relics left over from WriteEntity in the comments in Entity. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:30-31 Could you fix this comment. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:37 This one too. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:70 Could you split this into two. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:133 Could you change written to to accessed or something like that. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:152 here too. ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java:180 here too. REVISION DETAIL https://reviews.facebook.net/D2193 BRANCH svn > cleanup readentity/writeentity > ------------------------------ > > Key: HIVE-2838 > URL: https://issues.apache.org/jira/browse/HIVE-2838 > Project: Hive > Issue Type: Bug > Reporter: Namit Jain > Assignee: Namit Jain > Attachments: HIVE-2838.D2193.1.patch > > > Ideally, there should be one common entity instead of readentity/writeentity. > Unfortunately, that would be a backward incompatible change since users os > hive might have written > there own hooks, where they are using readentity/writeentity. > We should atleast create a common class, and then we can deprecate read/write > entity later, for a new release. > For now, I propose to make a backward compatible change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira