[ https://issues.apache.org/jira/browse/HIVE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2848: ------------------------------ Attachment: HIVE-2848.D2313.1.patch navis requested code review of "HIVE-2848 [jira] Add validation to HiveConf ConfVars". Reviewers: JIRA DPAL-970 Add validation to HiveConf ConfVars It would be good if we could add some validation to ConfVars in the HiveConf when they are set. At least if a variable is supposed to be boolean, numeric, or strict/nonstrict, it shouldn't be too difficult to check for these. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D2313 AFFECTED FILES cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java ql/src/test/queries/clientnegative/set_hiveconf_validation0.q ql/src/test/queries/clientnegative/set_hiveconf_validation1.q ql/src/test/queries/clientnegative/set_hiveconf_validation2.q ql/src/test/results/clientnegative/set_hiveconf_validation0.q.out ql/src/test/results/clientnegative/set_hiveconf_validation1.q.out ql/src/test/results/clientnegative/set_hiveconf_validation2.q.out MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/5139/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > Add validation to HiveConf ConfVars > ----------------------------------- > > Key: HIVE-2848 > URL: https://issues.apache.org/jira/browse/HIVE-2848 > Project: Hive > Issue Type: Improvement > Reporter: Kevin Wilfong > Assignee: Navis > Attachments: HIVE-2848.D2313.1.patch > > > It would be good if we could add some validation to ConfVars in the HiveConf > when they are set. > At least if a variable is supposed to be boolean, numeric, or > strict/nonstrict, it shouldn't be too difficult to check for these. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira