[
https://issues.apache.org/jira/browse/HIVE-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230683#comment-13230683
]
Phabricator commented on HIVE-2871:
-----------------------------------
kevinwilfong has commented on the revision "HIVE-2871 [jira] Add a new hook to
run at the beginning and end of the Driver.run method".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/HiveDriverRunHookContextImpl.java:25
The reason I didn't add it is that in other hook contexts (HookContext and
HiveSemanticAnalyzerHookContext) the SessionState is not included. Hooks can
get it via SessionState.get()
I don't really see the advantage of adding it, but if you feel strongly about
this I can.
REVISION DETAIL
https://reviews.facebook.net/D2331
> Add a new hook to run at the beginning and end of the Driver.run method
> -----------------------------------------------------------------------
>
> Key: HIVE-2871
> URL: https://issues.apache.org/jira/browse/HIVE-2871
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2871.D2331.1.patch, HIVE-2871.D2331.2.patch
>
>
> Driver.run is the highest level method which all queries go through, whether
> they come from Hive Server, the CLI, or any other entry. We also do not have
> any hooks before the compilation method is called, and having hooks in
> Driver.run would provide this. Having hooks in Driver.run will allow, for
> example, being able to overwrite config values used throughout query
> processing, including compilation, and at the other end, cleaning up any
> resources/logging any final values just before returning to the user.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
